This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Update Node version pre-flight check #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gnidan
commented
Jan 17, 2019
gnidan
commented
- Fix to match actual minimum requirement of v8.9.4
- Use semver to check compatibility
- Reörder imports nitpickingly
- Switch to "string"+"math" in case Node version doesn't support backtick syntax
- Reword error, remove line-break.
- Fix to match actual minimum requirement of v8.9.4
- Use semver to check compatibility
- Reörder imports nitpickingly
- Switch to "string"+"math" in case Node version doesn't support `${}`
- Reword error, remove line-break.
|
(Unrequesting review while I look into those tests) |
|
Thanks for cleaning up my mess @eggplantzzz :D |
|
Looks great! Into it... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.